Fix FetchForWriting with UseIdentityMapForAggregates and strongly typed IDs#17
Merged
jeremydmiller merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
…ates and strongly typed IDs Port of JasperFx/marten#4216. When UseIdentityMapForAggregates is true and the aggregate uses a strongly typed ID (e.g., PaymentId wrapping Guid), the identity map dictionary key type mismatch caused an InvalidCastException. The fix makes StoreAggregateInIdentityMap gracefully skip when the existing dictionary has an incompatible key type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of JasperFx/marten#4216 (fixes JasperFx/marten#4214).
InvalidCastExceptionwhen usingFetchForWriting()withUseIdentityMapForAggregates = trueand aggregates that have strongly typed IDsPaymentId), butFetchForWritingaccesses it using the raw stream identity type (Guid). The fix makesStoreAggregateInIdentityMapgracefully skip when the existing dictionary has an incompatible key type.Test plan
🤖 Generated with Claude Code